Closed klauer closed 3 years ago
ZLLentz
commented
3 years ago This looks really good with the tooltip expansion you suggested in the typhos PR, it adds functionality to the grid where you can figure out which circle is which at all times
ZLLentz
commented
3 years ago Immediate karma on the ci updates- I'll push a fix
ZLLentz
commented
3 years ago There's a deprecation/removal in python 3.9 that causes an issue with networkx < 2.5, and we have this gem in the travis output: https://app.travis-ci.com/github/pcdshub/lucid/jobs/522941507#L2381-L2383
Rather than muck with the conda recipe or travis builds here to make it pass I'm just going to mark 3.9 as an allowed failure for now
Description
I couldn't help but wonder how the new alarm functionality looked in typhos with https://github.com/pcdshub/typhos/pull/441
The answer is that it looks great! See the following view of RIX from psbuild in the grid:
which is an accurate reflection of the alarm state:
is similarly correctly determined:
And the tooltips are fantastic.
Context
Closes #86 (and steals a bit of Zach's thunder) Supersedes #89
Notes
Back-compat with the previous implementation may be unnecessary. If you feel strongly one way or another, I'd happily modify this PR.
If we decide to remove backward-compatibility of typhos, I'll adjust the version pin once the relevant PR is in and typhos is tagged. Otherwise, LUCID can be tagged/released independently.