MNT: update python and artifacts actions versions for nodejs warnings - Githubissues

pcdshub / pcds-ci-helpers

Repository for continuous integration scripts - for PLC-related work and otherwise

3 stars 7 forks source link

MNT: update python and artifacts actions versions for nodejs warnings #141

Closed tangkong closed 7 months ago

tangkong commented 7 months ago

I recently got warnings about nodejs deprecation for actions/setup-python and actions/upload-artifacts

setup-python seems to be a simple upgrade, but artifacts has breaking changes. Notably (from migration guide)

Artifacts are immutable, so we can't keep adding to artifacts like we used to (one example below)
- https://github.com/pcdshub/pcds-ci-helpers/blob/dd1c017d57aaff6dc58fe7bb0a94f9b654fa3d5a/.github/workflows/python-conda-test.yml#L183-L187
- https://github.com/pcdshub/pcds-ci-helpers/blob/dd1c017d57aaff6dc58fe7bb0a94f9b654fa3d5a/.github/workflows/python-conda-test.yml#L289-L293b
We can pull and merge artifacts to get similar results

tangkong commented 7 months ago

Turns out this doesn't really affect us much. I'll slap the bumps together and see what happens