search

pcdshub / pcdscalc

PCDS control system-agnostic scientific calculation routines
Other
0 stars 6 forks source link

Use pint for unit conversion #10

Closed cristinasewell closed 4 months ago

cristinasewell commented 3 years ago

Consider relying on pint for unit conversion.

Current Behavior

Using a dictionary units in the constants module.

Possible Solution

As we do it in pcdsdevices: https://github.com/pcdshub/pcdsdevices/blob/5ee91018658423b297e17a242f72b09bfcefc87e/pcdsdevices/utils.py#L93-L122

tangkong commented 4 months ago

Given the recent trouble we've had with pint and our decision to move away from it, I'm going to close this issue