search

pcdshub / pcdscalc

PCDS control system-agnostic scientific calculation routines
Other
0 stars 6 forks source link

ENH: Add lodcm calcs #9

Closed cristinasewell closed 3 years ago

cristinasewell commented 3 years ago

Added a new module diffraction for lodcm calculations. Added a new module common for some common calculations. Added a new module constants for constants, and moved some previous defined constants here.

Motivation and Context

These calculations are needed to support the following issues: https://github.com/pcdshub/pcdsdevices/issues/704 and https://github.com/pcdshub/pcdsdevices/issues/677

How Has This Been Tested?

Tested against the old functions.

Where Has This Been Documented?

Docstring

cristinasewell commented 3 years ago

Although these functions are used in the lodcm calculations, they are not specific to lodcm so I did not name the module specific to lodcm - but I can change it if needed.

There is only one function that is specific to lodcm - and in the old code this function belongs to the LOM object, so I might move this function out of here and have it in pcdsdevices/lodcm.py instead

ZLLentz commented 3 years ago

I think the current state of this PR is clean and as such will merge There's always opportunity for adding more later