pcdshub / pcdsdaq

Utilities for using the DAQ's pydaq, pycdb, and pyami libraries in conjunction with Bluesky
https://pcdshub.github.io/pcdsdaq
Other
0 stars 9 forks source link

DEV/MNT: migrate to latest standards with pyproject.toml [LCLSPC-603] #115

Closed klauer closed 1 year ago

klauer commented 1 year ago

Description

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

This PR and Jira LCLSPC-603

klauer commented 1 year ago

A few issues:

klauer commented 1 year ago

I reverted some type hints to fix the related issue for Python 3.9.

I'm not sure if the currently-failing test should be failing since Travis CI just didn't run on this repo previously. I'll ask for Zach to review and see what he thinks.

ZLLentz commented 1 year ago

Based on my docstrings and comments, the failing test is an actual failure (barring test setup error possibilities, etc.) I can make an issue to revisit:

klauer commented 1 year ago

OK, bypassing branch protection to merge with the acknowledgement that there is follow-up work to be done (#117, #118)