Closed klauer closed 1 year ago
A few issues:
int | float | None
is fine with from __future__ import annotations
but is problematic when we try to evaluate those type hints in Python < 3.10.
I reverted some type hints to fix the related issue for Python 3.9.
I'm not sure if the currently-failing test should be failing since Travis CI just didn't run on this repo previously. I'll ask for Zach to review and see what he thinks.
Based on my docstrings and comments, the failing test is an actual failure (barring test setup error possibilities, etc.) I can make an issue to revisit:
OK, bypassing branch protection to merge with the acknowledgement that there is follow-up work to be done (#117, #118)
Description
pyproject.toml
, replacingsetup.py
and related files.pyupgrade
.docs-versions-menu
replacesdoctr-versions-menu
anddoctr
usage for documentation deployment on GitHub Actions. The deployment key is now no longer required.pyupgrade
was used to update annotations, though there might not have been many herepycln
was used to clean up importsMotivation and Context
How Has This Been Tested?
Where Has This Been Documented?
This PR and Jira LCLSPC-603