pcdshub / pcdsdaq

Utilities for using the DAQ's pydaq, pycdb, and pyami libraries in conjunction with Bluesky
https://pcdshub.github.io/pcdsdaq
Other
0 stars 9 forks source link

ENH: Better error msg on connect, Deprecate platform arg #24

Closed ZLLentz closed 6 years ago

ZLLentz commented 6 years ago

Description

Motivation and Context

closes #5

How Has This Been Tested?

Tests added, and quality time spent in SXR testing with a real daq.

Where Has This Been Documented?

Change notes and docstring edits

codecov-io commented 6 years ago

Codecov Report

Merging #24 into master will decrease coverage by 0.23%. The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   99.47%   99.23%   -0.24%     
==========================================
  Files           2        2              
  Lines         381      393      +12     
==========================================
+ Hits          379      390      +11     
- Misses          2        3       +1
Impacted Files Coverage Δ
pcdsdaq/daq.py 99.44% <96.29%> (-0.27%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1bbf84...5bdf091. Read the comment docs.

ZLLentz commented 6 years ago

For the record it takes literally zero seconds to scan the platforms

teddyrendahl commented 6 years ago

And there are no use cases we run two DAQs on the same machine with different platforms?

ZLLentz commented 6 years ago

I can't imagine a single user deciding to run two DAQs off the same workstation rather than integrating all the devices into the same data stream.

ZLLentz commented 6 years ago

@teddyrendahl I also want to merge this one because it makes my testing easier. I can walk into any hutch and open hutch-python with no conf.yml and the daq just works. It's neat.