search

pcdshub / pcdsdevices

Collection of Ophyd device subclasses for IOCs unique to LCLS PCDS.
https://pcdshub.github.io/pcdsdevices/
Other
5 stars 58 forks source link

IMS.configure is not bluesky-compatible #1014

Open klauer opened 2 years ago

klauer commented 2 years ago

Source

https://github.com/pcdshub/pcdsdevices/blob/4c01ba8892215c535e7e6ee2ac5a418f5aea4a07/pcdsdevices/epics_motor.py#L717

Issue

The configure message expects a returned tuple of 'old, new' configuration dictionaries such that the configuration can be undone if need be.

https://github.com/bluesky/bluesky/blob/dc9819b7b903e3950cb79d0e473eb67c9c126327/bluesky/run_engine.py#L2305

ZLLentz commented 2 years ago

I think we should probably just rename this function as part of the other ongoing pmgr stuff