pcdshub / pcdsdevices

Collection of Ophyd device subclasses for IOCs unique to LCLS PCDS.
https://pcdshub.github.io/pcdsdevices/
Other
5 stars 58 forks source link

Lens4escan #1202

Open vespos opened 7 months ago

vespos commented 7 months ago

Description

Make lens stack class usable for energy scans with the CCM

Motivation and Context

This includes:

How Has This Been Tested?

Where Has This Been Documented?

Pre-merge checklist

DO NOT FORGET TO REMOVE https://github.com/pcdshub/pcdsdevices/pull/1202/files#diff-5a91e8b8e2d4fabd6201376dd1c45357ec3ccf379d64d91641b430e7cad6b84aR222 BEFORE MERGE

tangkong commented 7 months ago

Are we looking to merge this in addition to #1194 ? It seems like there's some duplicated work here

vespos commented 7 months ago

Yes, I expect https://github.com/pcdshub/pcdsdevices/pull/1194 to be merged first. This is sort of the next step and will likely take a bit more time. In the meantime I need that other PR code in here for now. I expect git to take care of making this nice once the other PR is merged and I merge master back into this one.