pcdshub / pcdsdevices

Collection of Ophyd device subclasses for IOCs unique to LCLS PCDS.
https://pcdshub.github.io/pcdsdevices/
Other
5 stars 58 forks source link

Typo in GammaController #1220

Open ZLLentz opened 5 months ago

ZLLentz commented 5 months ago

Current Behavior

Note the extra E: https://github.com/pcdshub/pcdsdevices/blob/f33a8b944ff501b1d7b37e8eef26544ffef81364/pcdsdevices/pump.py#L57

Expected Behavior

Here's the list of PVs for an gamma controller ion pump (LCLS1):

$ grep_pv CXI:R51:PCI:01
/reg/d/iocData/ioc-cxi-vacuum/iocInfo
CXI:R51:PCI:01:TODLOAD, "bo"
CXI:R51:PCI:01:ASHVEDES, "bo"
CXI:R51:PCI:01:ASPOWERDES, "bo"
CXI:R51:PCI:01:KEYLOCKDES, "bo"
CXI:R51:PCI:01:MASTERRESET, "bo"
CXI:R51:PCI:01:TODDY, "mbbi"
CXI:R51:PCI:01:TODDYDES, "mbbo"
CXI:R51:PCI:01:PEGUDES, "mbbo"
CXI:R51:PCI:01:TODMIDES, "ao"
CXI:R51:PCI:01:TODHRDES, "ao"
CXI:R51:PCI:01:TODMODES, "ao"
CXI:R51:PCI:01:TODDTDES, "ao"
CXI:R51:PCI:01:TODYRDES, "ao"
CXI:R51:PCI:01:ASHVE, "bi"
CXI:R51:PCI:01:ASPOWER, "bi"
CXI:R51:PCI:01:FAN, "bi"
CXI:R51:PCI:01:STREAMRELOAD, "sub"
CXI:R51:PCI:01:LINEV, "ai"
CXI:R51:PCI:01:LINEFREQ, "ai"
CXI:R51:PCI:01:MODEL, "stringin"
CXI:R51:PCI:01:TOD, "stringin"
CXI:R51:PCI:01:FWVERSION, "stringin"
CXI:R51:PCI:01:CHAN1NAME, "stringin"
CXI:R51:PCI:01:CHAN2NAME, "stringin"

Context / environment

Low priority typo when picking a device at random for a demo

Steps to Reproduce (for bugs)

from pcdsdevices.pump import GammaController
controller = GammaController("CXI:R51:PCI:01", name="controller")
controller.get()

Suggested Solution

Fix typo and search for related typos in same file