search

pcdshub / pcdsdevices

Collection of Ophyd device subclasses for IOCs unique to LCLS PCDS.
https://pcdshub.github.io/pcdsdevices/
Other
5 stars 58 forks source link

BTPS - Use Happi Devices for BtpsSourceStatus #1263

Open slactjohnson opened 1 month ago

slactjohnson commented 1 month ago

Current Behavior

The current BtpsSourceStatus uses PVs to create stage components. It might be useful to get these stages from the happi database rather than direct instantiation, as well as the cameras.

https://github.com/pcdshub/pcdsdevices/blob/ce9d569aed0a142f82b993237141e91c3aa4ad42/pcdsdevices/lasers/btps.py#L661-L669

Context / environment

We need to update some stages/cameras in the configuration. We have this information tracked in the code, rather than happi.

Suggested Solution

I'm not really sure which method is better; I just wanted to make an issue to track this idea.

tangkong commented 1 month ago

Having it in Happi let's us pull the device into typhos etc so there's that benefit.

It looks like the only common prefix is the first segment (LTLHN), but that's should make Happi instantiation ok