ENH: BTMS Camera Updates

slactjohnson commented 2 months ago

Description

Adds new methods to return the defined happi database names for the cameras in each bay. Updates existing methods to get camera prefixes. This PR extends the flexibility of the existing implementation and adds some new properties while being backwards compatible.

Motivation and Context

closes #1264

How Has This Been Tested?

Tested interactively using the BTMS in the laser hall.

Where Has This Been Documented?

This PR, and a related PR on pcdshub/btms-ui.

Pre-merge checklist

[x] Code works interactively
[x] Code contains descriptive docstrings, including context and API
[x] New/changed functions and methods are covered in the test suite where possible
[x] Test suite passes locally
[x] Test suite passes on GitHub Actions
[x] Ran docs/pre-release-notes.sh and created a pre-release documentation page
[x] Pre-release docs include context, functional descriptions, and contributors as appropriate

slactjohnson commented 2 months ago

@tangkong The camera properties are used here: https://github.com/pcdshub/btms-ui/blob/11ca69588c6b301070c17a751180c618ea991f02/btms_ui/widgets.py#L843-L873

Currently the "bay" property is used to construct the device name, but these new properties will allow me to update this to use the defined device names directly.

tangkong commented 2 months ago

Gotcha, thanks! https://github.com/pcdshub/btms-ui/pull/16 Looks like an improvement to me

pcdshub / pcdsdevices