There's some information that's hard-coded into the BTPS screens, and is duplicated by information in btps.py.
Expected Behavior
Information is not duplicated.
Context / environment
The same (or similar) information is already build into btps.py . When updating the stage mapping I fixed it in the code but forgot to do it in the screen, which caused confusion. I want to prevent this in the future.
Find a way to work the information present in btps.py into the screens. btps.py uses PVs, the screens use happi.... one method should be used, not both.
Current Behavior
There's some information that's hard-coded into the BTPS screens, and is duplicated by information in
btps.py.Expected Behavior
Information is not duplicated.
Context / environment
The same (or similar) information is already build into
btps.py. When updating the stage mapping I fixed it in the code but forgot to do it in the screen, which caused confusion. I want to prevent this in the future.btps.py: https://github.com/pcdshub/pcdsdevices/blob/665c1f40c68894e28ae611bb7708b8f18cea403e/pcdsdevices/lasers/btps.py#L661-L714Screens:
Related issue: https://github.com/pcdshub/pcdsdevices/issues/1269
Suggested Solution
Find a way to work the information present in
btps.pyinto the screens.btps.pyuses PVs, the screens usehappi.... one method should be used, not both.