pcdshub / pcdsdevices

Collection of Ophyd device subclasses for IOCs unique to LCLS PCDS.
https://pcdshub.github.io/pcdsdevices/
Other
5 stars 58 forks source link

Added new VCN_OpenLoop device class #1289

Closed jozamudi closed 6 days ago

jozamudi commented 1 week ago

Description

Added VCN_OpenLoop device class to pcdsdevices valve.py. VCN_OpenLoop uses VCN as a template w/ the removal of 'open' and 'position_readback' commands. The 'state' member vairable has been renamed to 'control_mode' and the associated doc string was been updated.

Motivation and Context

https://jira.slac.stanford.edu/browse/ECSENG-848

How Has This Been Tested?

Used Typhos to check if device would load correctly.

Where Has This Been Documented?

Screenshot from 2024-09-24 13-44-06

Pre-merge checklist

ZLLentz commented 1 week ago

Other than my docs note I see no problems here- I'd like to let Jing's approval gate the PR though, she has necessary context that I do not have.