pcdshub / pcdsdevices

Collection of Ophyd device subclasses for IOCs unique to LCLS PCDS.
https://pcdshub.github.io/pcdsdevices/
Other
5 stars 59 forks source link

Refactor PLC Classes to use PytmcSignal #389

Open ZLLentz opened 4 years ago

ZLLentz commented 4 years ago

Expected Behavior

Use PytmcSignal for all pytmc-originated variables

Current Behavior

Many PLC classes made before PytmcSignal made

Possible Solution

Take a deep breath and refactor

klauer commented 4 years ago

👍

I think we can start by listing the classes that are based on pytmc'd PLC IOCs. From there, converting won't be so bad. But we should also ensure that (PVs pre conversion) and (PVs post-conversion) are identical, per-device.