search

pcdshub / pcdsdevices

Collection of Ophyd device subclasses for IOCs unique to LCLS PCDS.
https://pcdshub.github.io/pcdsdevices/
Other
5 stars 59 forks source link

Valve Classes are Confusing #453

Open ZLLentz opened 4 years ago

ZLLentz commented 4 years ago

Expected Behavior

Not confusing

Current Behavior

VGC is not an instance of GateValve GateValve is an instance of Stopper PPSStopper is not an instance of Stopper Stopper is in a file called valve.py And maybe others

Unclear what to use to connect to LCLS2 vacuum and which bits to toggle for MPS things

Here is the class hierarchy, parents on the left and children on the right: GateValve > Stopper > InOutPositioner PPSStopper > InOutPositioner ValveBase > Device VGC > VRC > VVC > ValveBase VGCLegacy > ValveBase VVCNO > Device VCN > Device

Context

Trying to prototype some MPS test routines for Alex

ZryletTC commented 4 years ago

Sorry, I definitely contributed to this mess. I'll try to help reorganize.