search

pcdshub / pcdswidgets

LCLS PyDM Widget Library
https://pcdshub.github.io/pcdswidgets
Other
0 stars 10 forks source link

FIX: Readback PVs need to follow PyTMC conventions #20

Closed teddyrendahl closed 5 years ago

teddyrendahl commented 5 years ago

Closes #19

hhslepicka commented 5 years ago

Is there a clear way for us to cross check the references?

teddyrendahl commented 5 years ago

I would appreciate if @n-wbrown or @ghalym could make sure these are the correct suffixes

codecov-io commented 5 years ago

Codecov Report

Merging #20 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          15       15           
  Lines         944      944           
=======================================
  Hits          848      848           
  Misses         96       96
Impacted Files Coverage Δ
pcdswidgets/vacuum/gauges.py 91.42% <100%> (ø) :arrow_up:
pcdswidgets/vacuum/pumps.py 86.53% <100%> (ø) :arrow_up:
pcdswidgets/vacuum/valves.py 87.83% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc959bb...6268fc7. Read the comment docs.

ghalym commented 5 years ago

I checked all the the suffixes. The only one that doesn't match is the "Turbo Pump" : _interlock_suffix = ":ILK_STATUS". It should be ":ILK_OK".

Thank you.

hhslepicka commented 5 years ago

Thank you, @ghalym . I fixed the suffix for interlock at the new commit.