pcdshub / pcdswidgets

LCLS PyDM Widget Library
https://pcdshub.github.io/pcdswidgets
Other
0 stars 10 forks source link

Ebara EV_A pump #22

Closed domitto closed 5 years ago

domitto commented 5 years ago

Follow up on a pending email to Nolan: I'm working on the GMD HMI and I can't find a corresponding widget for the PRT:40 ebara EV_A pump. The only options for pumps are IonPump, TurboPump, ScrollPump or GetterPump. Is there any other pump with the same suffix or that requires a new roughing pump widget?

Thanks, Diego

hhslepicka commented 5 years ago

Hi @domitto , please use the ScrollPump for that.

domitto commented 5 years ago

That doesn't seem to match my IOC, these are the pvs associated with PRT40: ioc-tst-ads> dbgrep PRT fb:EM1K0:GMD:PRT:40:REMOTE fb:EM1K0:GMD:PRT:40:REMOTE_RBV fb:EM1K0:GMD:PRT:40:ALARM_OK_RBV fb:EM1K0:GMD:PRT:40:RUN_DI_RBV

This is what the scroll pump widget is looking for: ca://fb:EM1K0:GMD:PRT:40:RUN_SW ca://fb:EM1K0:GMD:PRT:40:STATE_RBV ca://fb:EM1K0:GMD:PRT:40:ERROR_RBV ca://fb:EM1K0:GMD:PRT:40:ILK_OK_RBV

hhslepicka commented 5 years ago

@ghalym do you mind to check the information? Yesterday you told me that ScrollPump sufixes would match for the Ebara Pump.

hhslepicka commented 5 years ago

This is a https://github.com/slaclab/pytmc issue.

klauer commented 5 years ago

STATE_RBV is still not in the vacuum library, but everything else for the PRT40 (Ebara Pump) should match up now as the issue was fixed in pytmc. Should we wait to close this until the state one is resolved?

Thanks for reporting, and sorry you have to keep running into these things, @domitto!

domitto commented 5 years ago

I'm in a similar situation for the Ebara Dry Pumps now and it looks like the scroll pump widget does not apply, these are the signals that I have: AT1K0:GAS:PMF:10:RUN_SW_RBV AT1K0:GAS:PMF:10:RUN_SW AT1K0:GAS:PMF:10:RUN_DO_RBV AT1K0:GAS:PMF:10:ILK_OK_RBV AT1K0:GAS:PMF:10:AT_SPD_RBV AT1K0:GAS:PMF:10:WARN_RBV AT1K0:GAS:PMF:10:ERROR_RBV AT1K0:GAS:PMF:10:MPStart_RBV AT1K0:GAS:PMF:10:BPStart_RBV AT1K0:GAS:PMF:10:MPStatus_RBV AT1K0:GAS:PMF:10:BPStatus_RBV AT1K0:GAS:PMF:10:ALARM_RBV AT1K0:GAS:PMF:10:REMOTE_RBV

ghalym commented 5 years ago

The Scroll pump widget has a subset of all those pvs :RUN_SW, ILK_OK_RBV, ERROR_RBV, STATE_RBV should also be there, since the ebara dry pump structure extends/inherits the scroll pump structure. So they all should share those widget pvs.

domitto commented 5 years ago

Thanks @ghalym !

hhslepicka commented 5 years ago

Closing issue as the equivalent widget was pointed out.