search

pcdshub / pcdswidgets

LCLS PyDM Widget Library
https://pcdshub.github.io/pcdswidgets
Other
0 stars 10 forks source link

FIX: Avoid flickering icon windows by creating icons with parents = self. #23

Closed hhslepicka closed 5 years ago

hhslepicka commented 5 years ago

Description

Icons were being created before the widgets resulting in windows without parent that were floating around. This caused a massive flickering effect when opening the designer via XForwarding.

Motivation and Context

Fix the issue above which is annoying.

How Has This Been Tested?

Tested locally.

Where Has This Been Documented?

codecov-io commented 5 years ago

Codecov Report

Merging #23 into master will increase coverage by 0.46%. The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   89.62%   90.08%   +0.46%     
==========================================
  Files          15       15              
  Lines        1002     1009       +7     
==========================================
+ Hits          898      909      +11     
+ Misses        104      100       -4
Impacted Files Coverage Δ
pcdswidgets/vacuum/base.py 87.09% <100%> (+3.31%) :arrow_up:
pcdswidgets/vacuum/gauges.py 91.42% <100%> (ø) :arrow_up:
pcdswidgets/vacuum/pumps.py 86.53% <100%> (ø) :arrow_up:
pcdswidgets/vacuum/others.py 76.47% <100%> (ø) :arrow_up:
pcdswidgets/vacuum/valves.py 83.65% <66.66%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79de2f1...f2f5fb9. Read the comment docs.