search

pcdshub / pcdswidgets

LCLS PyDM Widget Library
https://pcdshub.github.io/pcdswidgets
Other
0 stars 10 forks source link

REF: Refactor to move functions to places where it makes more sense. #35

Closed hhslepicka closed 4 years ago

hhslepicka commented 4 years ago

Description

Refactor the way we show the expert screens. This code depends on a Typhos PR that will come up soon.

Motivation and Context

Make the code simpler.

Closes https://github.com/pcdshub/pcdswidgets/issues/33 and https://github.com/pcdshub/pcdswidgets/issues/32

Dependencies

This PR depends on https://github.com/pcdshub/typhos/pull/245 and https://github.com/pcdshub/pcdsutils/pull/4

codecov-io commented 4 years ago

Codecov Report

Merging #35 into master will increase coverage by 1.87%. The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #35      +/-   ##
=========================================
+ Coverage   85.53%   87.4%   +1.87%     
=========================================
  Files          15      15              
  Lines        1134    1104      -30     
=========================================
- Hits          970     965       -5     
+ Misses        164     139      -25
Impacted Files Coverage Δ
pcdswidgets/utils.py 68.42% <ø> (+35.69%) :arrow_up:
pcdswidgets/vacuum/base.py 79.89% <12.5%> (-2.7%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e12359f...912172c. Read the comment docs.