pcdshub / pcdswidgets

LCLS PyDM Widget Library
https://pcdshub.github.io/pcdswidgets
Other
0 stars 10 forks source link

Pirani/Rough gauge widget state pv #43

Closed ghalym closed 4 years ago

ghalym commented 4 years ago

Initially it was agreed that this widget state pv is :PRESS_OK_RBV. All other widgets read STATE_RBV, making this the odd one out. Can we change the state of the widget to be linked to the STATE_RBV instead? I understand we will need to update the stylesheets accordingly, but will it have any other effect?

hhslepicka commented 4 years ago

State is very straightforward. You will only need to adjust the stylesheets if the enum strings changed between one PV and the other... otherwise not even that is required. Knowing that, should I move forward with the change?

ghalym commented 4 years ago

Yes please. Thank you for the quick response.