search

pcdshub / pcdswidgets

LCLS PyDM Widget Library
https://pcdshub.github.io/pcdswidgets
Other
0 stars 10 forks source link

DEV: updated Fastshutter's error_suffix to STATE_RBV in valve.py #49

Closed slacAdpai closed 4 years ago

slacAdpai commented 4 years ago

Description

Fixes half of #48

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

codecov-commenter commented 4 years ago

Codecov Report

Merging #49 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files          16       16           
  Lines        1145     1145           
=======================================
  Hits          988      988           
  Misses        157      157
Impacted Files Coverage Δ
pcdswidgets/vacuum/valves.py 85.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cf7f2c...a80c36f. Read the comment docs.

hhslepicka commented 4 years ago

Thank you, @slacAdpai, for getting the job started. I am verifying with @ghalym at the issue to discuss about the command button.

hhslepicka commented 4 years ago

@slacAdpai this was a small change but next time please wait for a review before merging.

slacAdpai commented 4 years ago

@hhslepicka Yes, I'll make sure to check it passed review next time.