search

pcdshub / pcdswidgets

LCLS PyDM Widget Library
https://pcdshub.github.io/pcdswidgets
Other
0 stars 10 forks source link

New Widget Pneumatic Valve with Readback Normally Open #59

Closed ghalym closed 3 years ago

ghalym commented 3 years ago

TMO has pneumatic valves installed that are normally open with limits switch readback, and we need a new widget for them.

Expected Behavior

The behavior of this widget is similar to the that of a pneumatic valve. The difference is that it is commanded to close instead of commanded to open. image

hhslepicka commented 3 years ago

@ghalym about the icon, should we reuse an icon that is already there or do we need to develop a custom one for this widget?

jyin999 commented 3 years ago

I prefer to use the same VGC icon. We use the same icon for NO and NC VGC before.

ghalym commented 3 years ago

@jyin999 how about we add the letters NO next to t he top rectangle?

jyin999 commented 3 years ago

@ghalym I like it.

jyin999 commented 3 years ago

@hhslepicka any update?

hhslepicka commented 3 years ago

@jyin999 I am on vacation. I can work on it early January.

jyin999 commented 3 years ago

@hhslepicka Early January is good. Thank you. Have a great holiday time!

hhslepicka commented 3 years ago

@jyin999 and @ghalym does this look like what you are looking for? image

I will also need the name of the Ophyd class to use for the Expert Screen. The VGC uses: EXPERT_OPHYD_CLASS = "pcdsdevices.valve.VGC"

jyin999 commented 3 years ago

@hhslepicka @ghalym Good for me.