Closed ZLLentz closed 2 years ago
This is collecting dust. I'm going to make the tests pass, ask for a review, merge, and move the rest of the todo items into an issue.
A big uncommitted comment block I found on my NFS clone, I must have been trying to figure out the remaining bullet points:
+# For showing/hiding individual rows (filter exceptions), we can
+# Add an extra column at the start that unhides when we enter config mode
+# The extra column has a combobox with the show/hide/auto options
+# When we filter, we check this combobox first. Show is always shown, etc.
+# For saving, we can probably just need:
+# - macros for each row in the current logical order
+# - the current logical-visual mapping
+# - the current show/hide/auto
+# - the current filter options
+# For loading, we create the rows from the macros file in order,
+# then move the visual ordering of the header to match the previous mapping.
+# Saving and loading can be in the right-click menu
+# For increasing the size on larger monitors... I have no idea.
Seems to still work using the TMO screen, though the performance isn't great when you have a lot of items and/or ask for new sorts.
Created #70 with follow-up information
This closes #69
Oh man, sorry this is so messy. I'll have to come back to this one before merging I guess... it's really awkward because it's deployed as-is in dev.
I don't think any of what I suggested are really so bad, but rather have places for easy improvements. I'd be totally OK with merging/tagging and letting you circle back to this if/when you get time.
I kind of disagree, I don't like to compromise on code quality. The important thing to cut off here to ensure it gets merged is the scope, not the small tweaks.
Ok, this PR next. To-do:
I think I've gotten all the biggest fixes done. I'm going to merge this and move on.
Description
Add the
FilterSortWidgetTable
widget. This widget allows us to repeat a template generically in a table form, and handle things like sorting and filtering in a re-usable way.Here's a screenshot of the TMO screen I am working on that uses this widget:
Features:
Motivation and Context
This is a common motif and we should be able to re-use it in multiple contexts
How Has This Been Tested?
Only interactiveley so far
Where Has This Been Documented?
Only docstrings so far