search

pcdshub / pcdswidgets

LCLS PyDM Widget Library
https://pcdshub.github.io/pcdswidgets
Other
0 stars 10 forks source link

API: Symbols to Vacuum #8

Closed teddyrendahl closed 5 years ago

teddyrendahl commented 5 years ago

It isn't really clear what the difference is between symbols and icons based on name alone. I have moved all of the symbols references to be vacuum instead.

I also moved the utils to be a single file not a directory. I'd like to encourage a common location for these kind of Qt helper functions ....

codecov-io commented 5 years ago

Codecov Report

Merging #8 into master will increase coverage by 0.65%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage    90.5%   91.15%   +0.65%     
==========================================
  Files          15       15              
  Lines         916      916              
==========================================
+ Hits          829      835       +6     
+ Misses         87       81       -6
Impacted Files Coverage Δ
pcdswidgets/vacuum/gauges.py 100% <ø> (ø)
pcdswidgets/vacuum/__init__.py 100% <ø> (ø)
pcdswidgets/vacuum/base.py 85.71% <ø> (ø)
pcdswidgets/vacuum/pumps.py 91.3% <ø> (ø)
pcdswidgets/vacuum/valves.py 93.75% <ø> (ø)
pcdswidgets/vacuum/mixins.py 89.49% <ø> (ø)
pcdswidgets/utils.py 100% <ø> (ø)
pcdswidgets/vacuum/others.py 76.47% <ø> (ø)
pcdswidgets/designer.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2760920...db09d90. Read the comment docs.