add new lines to the start and end of each structured text section

aeu485 commented 12 months ago

Addresses #10. Works upon ST declaration and implementations, with the --lines argument for specifying additional \n. Two modifications occur from the use ElementTree.Write:

xml version line changes from double to single quotes and encoding is capitalized <?xml version="1.0" encoding="utf-8"?> becomes <?xml version='1.0' encoding='UTF-8'?>
Folder tags Id attributes lose a space at their end <Folder Name="internal" Id="{ad4fec99-008a-4786-b366-d1f41be17bb4}" /> becomes <Folder Name="internal" Id="{ad4fec99-008a-4786-b366-d1f41be17bb4}"/>

ZLLentz commented 7 months ago

This is well implemented and a good addition, thank you! I'm stalling out a bit on review due to some busy season/staffing shortages, it will take me a bit longer to verify the versioneer update (I know it's stock and standard, but it's also a big diff and I can't accept it without reviewing it thoroughly)

aeu485 commented 7 months ago

No problem. I removed the versioneer updates as you didn't update in your most recent PR either.

ZLLentz commented 6 months ago

merging and then I'm going to make a mini follow-up PR to rename the file so it will run from the pre-commit binary

thank you for your contribution and your patience!

pcdshub / pre-commit-hooks

add new lines to the start and end of each structured text section #23