search

pcdshub / pre-commit-hooks

Pre-commit hooks for PCDS projects (https://pre-commit.com/)
Other
10 stars 7 forks source link

Tc version check #29

Closed rruiter87 closed 4 months ago

rruiter87 commented 5 months ago

Added the proposed hook as discussed in #28

When run on the current TcOpen repo I get this

Not all files have the same TwinCAT version:
 -src/IntegrationProjects/src/XAE/XAE/XAEIntegrationProjects.tsproj: 3.1.4024.22
 -src/Tc.Prober/tests/TcProber/TcProber.tsproj: 3.1.4024.22
 -src/TcOpen.Hammer/TcOpenHammer/TcOpenHammer/TcOpenHammer.tsproj: 3.1.4024.25
 -src/TcoAbbRobotics/src/XaeTcoAbbRobotics/XaeTcoAbbRobotics.tsproj: 3.1.4024.44
 -src/TcoAbstractions/src/XAE/XAE/XAETcoAbstractions.tsproj: 3.1.4024.32
 -src/TcoAimTtiPowerSupply/src/XaeTcoAimTtiPowerSupply/XaeTcoAimTtiPowerSupply.tsproj: 3.1.4024.44
 -src/TcoApplicationExamples/XaeAppExamples/XaeAppExamples.tsproj: 3.1.4024.22
 -src/TcoCognexVision/src/XAE/XAE/XAETcoCognexVision.tsproj: 3.1.4024.55
 -src/TcoCore/src/XaeTcoCore/XaeTcoCore.tsproj: 3.1.4024.55
 -src/TcoData/src/XAE/XAE/XAETcoData.tsproj: 3.1.4024.55
 -src/TcoDrivesBeckhoff/src/XaeTcoDrivesBeckhoff/XaeTcoDrivesBeckhoff.tsproj: 3.1.4024.55
 -src/TcoElements/src/XAE/XAE/XAETcoElements.tsproj: 3.1.4024.44
 -src/TcoInspectors/src/XAE/XAE/XAETcoInspectors.tsproj: 3.1.4024.55
 -src/TcoIo/src/XAE/XAE/XAETcoIo.tsproj: 3.1.4024.32
 -src/TcoKukaRobotics/src/XaeTcoKukaRobotics/XaeTcoKukaRobotics.tsproj: 3.1.4024.44
 -src/TcoMitsubishiRobotics/src/XaeTcoMitsubishiRobotics/XaeTcoMitsubishiRobotics.tsproj: 3.1.4024.44
 -src/TcoPneumatics/src/XaeTcoPneumatics/XaeTcoPneumatics.tsproj: 3.1.4024.44
 -src/TcoRexrothPress/src/XAE/XAE/XAETcoRexrothPress.tsproj: 3.1.4024.32
 -src/TcoTixonFeeding/src/XaeTcoTixonFeeding/XaeTcoTixonFeeding.tsproj: 3.1.4024.55
 -src/TcoUrRobotics/src/XaeTcoUrRobotics/XaeTcoUrRobotics.tsproj: 3.1.4024.44
 -src/TcoUtilities/src/XAE/XAE/XAETcoUtilities.tsproj: 3.1.4024.44
 -src/librarytemplate/src/XAE/XAE/XAEPlcTemplate.tsproj: 3.1.4024.32
rruiter87 commented 5 months ago

Thanks for the detailed review!

rruiter87 commented 4 months ago

Awesome. And thank you for the extensive review. 👍