Closed klauer closed 5 years ago
Merging #108 into master will increase coverage by
0.37%
. The diff coverage is93.33%
.
@@ Coverage Diff @@
## master #108 +/- ##
========================================
+ Coverage 74.62% 75% +0.37%
========================================
Files 15 15
Lines 1600 1612 +12
========================================
+ Hits 1194 1209 +15
+ Misses 406 403 -3
Impacted Files | Coverage Δ | |
---|---|---|
pytmc/pragmas.py | 97.7% <100%> (+0.02%) |
:arrow_up: |
pytmc/parser.py | 83.36% <100%> (+0.94%) |
:arrow_up: |
pytmc/record.py | 93.82% <88.88%> (-0.41%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0492cfe...c154ceb. Read the comment docs.
Confirmed locally - instead of 81
for all strings, it gets the correct value now.
👍
Discovered by @ZLLentz, this bug caused arrays to be represented as scalar records (i.e., not
waveform
) in the EPICS db.This now generates what appears to be correct to me:
(This also shows we have a lot of holes in the test suite, which probably shouldn't be a surprise given how much I thrashed it...)