Closed klauer closed 5 years ago
Merging #118 into master will decrease coverage by
0.38%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 76.3% 75.91% -0.39%
==========================================
Files 16 16
Lines 1760 1769 +9
==========================================
Hits 1343 1343
- Misses 417 426 +9
Impacted Files | Coverage Δ | |
---|---|---|
pytmc/bin/stcmd.py | 65.54% <0%> (-5.37%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2636c09...4c27e6e. Read the comment docs.
@ZLLentz the proposed DUT_*
refactor should be based on this code.
@klauer I'll start the refactor with a branch off of this branch. Is this ready for review? I think it looks good.
Yes, it should be ready for review.
Sounds good, @n-wbrown - apologies for the lazy coding! Since @ZLLentz's PR relies on this one, I'd like to merge this and push the docstring commit to his PR (or a separate one altogether). That OK?
There are some finer points about this that need to be discussed at some point, but for now this PR just fixes the usage of a pytmc pragma on an FB_MotionStage in conjunction with the stcmd generation script:
Bug:
Looks like
pragmas
functions were tweaked andstcmd
was not updated to follow that - another hole in the test suite.Now an
FB_MotionStage
with a pragma ofpv: my:prefix:AXIS1
will correctly generate the following:and a filter of the form
{{motor|pragma('precision', 3) }}
will get theprecision:
field from theFB_MotionStage
pragma as well.