search

pcdshub / pytmc

Generate EPICS IOCs and records from TwinCAT projects - along with many TwinCAT project tools
https://pcdshub.github.io/pytmc/
Other
10 stars 11 forks source link

FIX: make T_MaxString:=STRING(255) #125

Closed klauer closed 5 years ago

klauer commented 5 years ago

pytmc expanded the T_MaxString to a basic data type, which did not have a pytmc pragma and was therefore ignored. This could be considered a workaround (or, ahem, hack). Confirmed working with the PMPS library.

Fancy "typedefs" such as this may trip us up again in the future and perhaps require a bit more thought.

codecov-io commented 5 years ago

Codecov Report

Merging #125 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage    78.6%   78.65%   +0.04%     
==========================================
  Files          16       16              
  Lines        1809     1813       +4     
==========================================
+ Hits         1422     1426       +4     
  Misses        387      387
Impacted Files Coverage Δ
pytmc/parser.py 86.64% <100%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cad44f0...35026c5. Read the comment docs.