Closed klauer closed 4 years ago
:exclamation: No coverage uploaded for pull request base (
master@06a68f6
). Click here to learn what that means. The diff coverage is80%
.
@@ Coverage Diff @@
## master #129 +/- ##
=========================================
Coverage ? 78.82%
=========================================
Files ? 16
Lines ? 1823
Branches ? 0
=========================================
Hits ? 1437
Misses ? 386
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
pytmc/parser.py | 87.31% <80%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 06a68f6...57e03db. Read the comment docs.
The UTF-8 BOM was causing pytmc running on Windows to bail immediately with the message:
Enums were apparently also being ignored in some (all?) cases in recent builds. b79f4a9 attempts to fix that by ensuring
DataType.walk()
is always yielding something, allowing for the creation of chains.Confusing implementation detail: enums should be seen to pytmc in a way similar to a built-in type (UINT + some metadata), and as
BuiltInType
yields[]
forwalk()
this PR brings it in line with that.~One test is now failing as a previously-ignored enum is now found to be duplicated...~ The pragma was already fixed upstream; updated to master in 53aa27f.