klauer commented 4 years ago

Closes #41

Defaults are specified in classes from pytmc.record. These can be overridden by using specific keys in the pragmas:

        To apply to either input or output records, pragma keys `autosave_pass0`
        or `autosave_pass1` can be used.

        To only apply to input records, pragma keys `autosave_input_pass0`
        `autosave_input_pass1` can be used.

        To only apply to output records, pragma keys `autosave_output_pass0`
        `autosave_output_pass1` can be used.

More info in the documentation commit (see diff).

I have not given the defaults much thought, but with this PR as a basis we can fill in those details later.

codecov-io commented 4 years ago

Codecov Report

Merging #137 into master will decrease coverage by <.01%. The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   77.78%   77.77%   -0.01%     
==========================================
  Files          17       17              
  Lines        1904     1917      +13     
==========================================
+ Hits         1481     1491      +10     
- Misses        423      426       +3

Impacted Files	Coverage Δ
pytmc/record.py	`91.66% <80%> (-1.01%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee7cd05...c916fb5. Read the comment docs.

klauer commented 4 years ago

Rebased on master - ready for review.

klauer commented 4 years ago

We'll probably revisit the default autosave fields at some point, but this is probably good-to-go? ~Will merge by COB unless there are more issues to resolve.~ Confirmed with @ZLLentz in person - merging.

pcdshub / pytmc

ENH: add autosave support #137

Codecov Report