pcdshub / pytmc

Generate EPICS IOCs and records from TwinCAT projects - along with many TwinCAT project tools
https://pcdshub.github.io/pytmc/
Other
10 stars 11 forks source link

ENH: add preliminary archive file support #162

Closed klauer closed 4 years ago

klauer commented 4 years ago

Closes #139

See the related issue + docs for further information.

codecov-io commented 4 years ago

Codecov Report

Merging #162 into master will increase coverage by 0.76%. The diff coverage is 91.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   78.63%   79.39%   +0.76%     
==========================================
  Files          17       17              
  Lines        2031     2097      +66     
==========================================
+ Hits         1597     1665      +68     
+ Misses        434      432       -2
Impacted Files Coverage Δ
pytmc/bin/pytmc.py 80.85% <100%> (+0.85%) :arrow_up:
pytmc/bin/pragmalint.py 84.37% <100%> (+0.6%) :arrow_up:
pytmc/bin/db.py 48.48% <80%> (+3.54%) :arrow_up:
pytmc/pragmas.py 96.33% <89.18%> (+1.18%) :arrow_up:
pytmc/record.py 94.25% <97.82%> (+1.78%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d4d9d3...e97c49d. Read the comment docs.

klauer commented 4 years ago

As you'll likely be one of the first users, @ZLLentz, feel free to chime in if the PR makes sense from the perspective of defaults + pragmas. Review-wise @n-wbrown has things covered - unless you feel so inclined.

n-wbrown commented 4 years ago

This all looks very solid to me. You can merge when ready.