search

pcdshub / pytmc

Generate EPICS IOCs and records from TwinCAT projects - along with many TwinCAT project tools
https://pcdshub.github.io/pytmc/
Other
10 stars 11 forks source link

FIX: off by one error in complex array unrolling #170

Closed ZLLentz closed 4 years ago

ZLLentz commented 4 years ago

The off-by-one error in array bounds fix in #169 created a new off-by-one error in the code introduced in #121 that was relying on the previously off-by-one value. This fixes the issue.

ZLLentz commented 4 years ago

Yeah, I suppose it didn't really matter, but now it matches the numbers you designate in the beckhoff PLC. I checked that nothing else relied on this already but I was basically just hoping that the tests would pass :man_shrugging:

codecov-io commented 4 years ago

Codecov Report

Merging #170 into master will increase coverage by 0.16%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   79.39%   79.56%   +0.16%     
==========================================
  Files          17       17              
  Lines        2097     2114      +17     
==========================================
+ Hits         1665     1682      +17     
  Misses        432      432
Impacted Files Coverage Δ
pytmc/pragmas.py 96.33% <100%> (ø) :arrow_up:
pytmc/bin/stcmd.py 86.99% <0%> (ø) :arrow_up:
pytmc/parser.py 88.35% <0%> (+0.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e6c6732...a92f244. Read the comment docs.