Closed klauer closed 3 years ago
Do you want a post-review? I see the ready for review followed by merge
Oh sure, would be happy for input if you're up for it @ZLLentz. (I assumed these PRs were too specialized/boring to get any real reviews...)
Just trying to follow the process, I'll give it a look through
Perhaps predictably, I don't have much to say about the implementation, except that I noted a few things that seem cleaner than how I usually set these up.
I think this is a neat feature that really gets to the core of what a generalized pytmc
tool should be. You could make all sorts of things with this.
Glad there was nothing majorly wrong here - thanks for taking a look 👍
I'm pretty positive on the outlook of the tool. It took more than few iterations to get here, but such is the nature of these projects... Would be curious if you had any ideas for PCDS-wide PLC summaries at some point (quick look-up table saying "this axis is on this PLC; these PLCs are running these library versions, ..." - https://github.com/pcdshub/plc-summary which I didn't get very far with yet)
Oh man we could do a lot with that... Axes are a good start, hopefully a lot of those projects have the motor PV name linked in a useful way too?
I wonder if we could track things like:
Good ideas - though the CoE startup settings would probably be too much/annoying. Would still like to decode those common ones, one day, and include them in per-project summaries.
Actually, I'm going to nab your comment and make an issue over in the summary project - hope you don't mind.
First pass at #209
Additionally enables projects such as https://github.com/pcdshub/plc-summary.
Fortunately this is still consistent with what I had intended with ads-deploy (at least according to my old comment, as I didn't recall): https://github.com/pcdshub/ads-deploy/blob/c7048848e284a5ba35245fe2f5943824fa4a6065/ads_deploy/docs.py#L11-L13