Investigate qtpy dependency

pcdshub / pytmc

Generate EPICS IOCs and records from TwinCAT projects - along with many TwinCAT project tools

https://pcdshub.github.io/pytmc/

Other

10 stars 11 forks source link

Investigate qtpy dependency #253

Open ZLLentz opened 3 years ago

ZLLentz commented 3 years ago

This is listed as required for the test, in the conda-recipe, which is just an import of pytmc, while not being listed in the requirements for the package.
It is listed in dev-requirements.txt but not in requirements.txt.
It is used in bin/types.py, which is a debugging interface, but also a command-line option for the cli entry point.

klauer commented 3 years ago

It's considered "optional". If qtpy is unavailable, pytmc types will similarly be unavailable (with a message in pytmc --help indicating the reason for it).

There are hooks in the conda recipe to specify optional dependencies. We have no specific version requirement here, but perhaps it'd be worth listing in that section regardless.

ZLLentz commented 3 years ago

Ok, that makes sense. So in general this doesn't even belong in the testing section of the conda recipe? And instead belongs in optional dependencies, explicitly?

klauer commented 3 years ago

Well, we do actually run tests with it. If we're going to start using the test dependency section in the conda recipes (*) then it should be listed there. Otherwise, optional deps for now.

(*) I think we should consider this at some point - I either mentioned that in chat or opened an issue, I can't recall!

ZLLentz commented 3 years ago

Right, you opened an issue somewhere. I was more referring to the fact that it's listed as a requirement for the tests, and since the test is just an import, it implies that it is required to do the import, which logically makes it a non-optional dependency.

klauer commented 3 years ago

Oh... oh... I'm a little slow/distracted this morning - apologies. I should just wait to comment on these.

ZLLentz commented 3 years ago

Treat this issue as "Zach got confused while reviewing the conda-forge PR because of this dependency"