search

pcdshub / pytmc

Generate EPICS IOCs and records from TwinCAT projects - along with many TwinCAT project tools
https://pcdshub.github.io/pytmc/
Other
10 stars 11 forks source link

Axis Id attribute of top-level NC.xti Axis may differ from per-axis .XTI Axis Id attribute [LCLSECSD-730] #277

Open klauer opened 2 years ago

klauer commented 2 years ago

When saved in a separate file, the Axis Id attribute of top-level NC.xti Axis may differ from per-axis .XTI Axis Id attribute.

We currently use the axis one and not the NC-defined one.

https://github.com/pcdshub/pytmc/blob/411820b1448d726f7fc12e511a21e517c72f3ad4/pytmc/parser.py#L1759-L1762

TODO: Warn (or error) if the two differ to avoid confusion in the future.

e.g., https://github.com/Mbosum/lcls-plc-lamp-lv17-motion/blob/bfba8bc10cd8ad05ffd1c757fd00a421e3cebfe5/lcls-plc-lamp-lv17-motion/_Config/NC/NC.xti#L22 vs https://github.com/Mbosum/lcls-plc-lamp-lv17-motion/blob/bfba8bc10cd8ad05ffd1c757fd00a421e3cebfe5/lcls-plc-lamp-lv17-motion/_Config/NC/Axes/SamplePaddleX.xti#L1350

slactjohnson commented 2 years ago

Related to JIRA ticket here: https://jira.slac.stanford.edu/browse/LCLSECSD-730