search

pcdshub / pytmc

Generate EPICS IOCs and records from TwinCAT projects - along with many TwinCAT project tools
https://pcdshub.github.io/pytmc/
Other
10 stars 11 forks source link

Unit tests are failing on latest tag #295

Closed ZLLentz closed 1 year ago

ZLLentz commented 1 year ago

Unit test outputs on travis have many instances of:

>           templated = template_main([project_filename], template=template_fp)
E           TypeError: main() got an unexpected keyword argument 'template'

sourced from https://github.com/pcdshub/pytmc/blob/master/pytmc/tests/test_commandline.py

It looks like we changed the template kwarg to templates: https://github.com/pcdshub/pytmc/blob/85fa86d9a716651aee70831e5bb8f69cc9566eed/pytmc/bin/template.py#L680 But I'm very confused because the master was passing with this in it

Failing tags: https://app.travis-ci.com/github/pcdshub/pytmc/builds/254953822 https://app.travis-ci.com/github/pcdshub/pcds-envs/builds/255486106

Was passing on master prior to the tag (with failing docs...): https://app.travis-ci.com/github/pcdshub/pytmc/builds/254263773

ZLLentz commented 1 year ago

On closer inspection, the master build was actually failing but was marked as a success (because coverage passed?) I think Ken fixed this CI issue recently but this PR came before that

ZLLentz commented 1 year ago

I'll do a quick PR because it should be a simple test suite only tweak and I only found this from looking at the full env cron job