search

pcdshub / pytmc

Generate EPICS IOCs and records from TwinCAT projects - along with many TwinCAT project tools
https://pcdshub.github.io/pytmc/
Other
10 stars 11 forks source link

TST: test suite was using old kwarg, swap to new #296

Closed ZLLentz closed 1 year ago

ZLLentz commented 1 year ago

closes #295 probably see linked issue for details

ZLLentz commented 1 year ago

More small edits needed: apparently the old interface wanted a file-handle-like object (and I think my local build is skipping these tests for some reason?)

ZLLentz commented 1 year ago

haha ok, specifically I need to give a string filepath, while the old tests were written assuming that passing a file-like object is ok turnaround would be faster on this if the tests weren't skipping themselves in my env

ZLLentz commented 1 year ago

Test were skipping for me because I forgot to clone with submodules, classic error

Hopefully this is all that's left because I have relearned that no test suite change is ever simple/easy/quick

ZLLentz commented 1 year ago

I'd appreciate a brief re-review @klauer since when you took a look it was only a two line change with two characters added