Closed ZLLentz closed 1 year ago
More small edits needed: apparently the old interface wanted a file-handle-like object (and I think my local build is skipping these tests for some reason?)
haha ok, specifically I need to give a string filepath, while the old tests were written assuming that passing a file-like object is ok turnaround would be faster on this if the tests weren't skipping themselves in my env
Test were skipping for me because I forgot to clone with submodules, classic error
Hopefully this is all that's left because I have relearned that no test suite change is ever simple/easy/quick
I'd appreciate a brief re-review @klauer since when you took a look it was only a two line change with two characters added
closes #295 probably see linked issue for details