FIX: hotfix for couple issues found on plcprog-console

pcdshub / pytmc

Generate EPICS IOCs and records from TwinCAT projects - along with many TwinCAT project tools

https://pcdshub.github.io/pytmc/

Other

10 stars 11 forks source link

FIX: hotfix for couple issues found on plcprog-console #317

Closed klauer closed 1 year ago

klauer commented 1 year ago

Related to #299 but may not necessarily close it (it's a bit of a hack)
Patches over bizarre DUT_MotionStage aliasing issue where sphinx was failing to find the nc_axis attribute of Symbol_ST_MotionStage instances and trying to use __getitem__ on it (x.nc_axis -> x["nc_axis"]) and throwing nonsensical errors in the meantime
- This was evaluated from this line in the IOC startup script: https://github.com/pcdshub/ads-ioc/blob/98b6bbd49c2433ae9ddc962ec229732cfa8ecbde/iocBoot/templates/st.cmd.template#L156C17-L156C17

ZLLentz commented 1 year ago

This did pass the unit tests last time, right? I can't comprehend how these changes would cause the st.cmds to generate without the motion sections...

klauer commented 1 year ago

So perhaps I fixed DUT_MotionStage and broke ST_MotionStage with the parsing utilities? More to investigate tomorrow :sigh: ...

ZLLentz commented 1 year ago

This behavior is reproducible offline using my random lfe motion plc project clone (which is all DUT_MotionStage)

ZLLentz commented 1 year ago

This must be related to the specifics of the st.cmd template that I edited to search for ST_MotionStage

klauer commented 1 year ago

Back to draft with this one - not an appropriate fix here.

This quick "fix" hid the issue rather than resolved it. Hmm...

klauer commented 1 year ago

Yeah, upon further investigation this is very much not the right fix. Test suites to the rescue!