`:T_CALC` should be renamed to not be confused with "current transmission"

pcdshub / solid-attenuator

LCLS Solid Attenuator System IOC

https://pcdshub.github.io/solid-attenuator

Other

1 stars 4 forks source link

`:T_CALC` should be renamed to not be confused with "current transmission" #18

Closed rajanplumley closed 4 years ago

rajanplumley commented 4 years ago

https://github.com/pcdshub/hxr-attenuator/blob/dabdc3f68ebb032dda78351d8f71b7ef66c6d46f/caproto/ioc-satt-dev/db/system.py#L10

This PV is the total transmission of all the filters together, which is useful for calculating the transmissions of the configurations matrix. It is not a readback of the transmission through the current filter configuration ( which requires awareness of the current filter position states ).

klauer commented 4 years ago

How does T_CALC_ALL sound? (i.e., transmission value calculated from all filters)

klauer commented 4 years ago

Resolved in a recent PR. Thanks!