search

pcdshub / solid-attenuator

LCLS Solid Attenuator System IOC
https://pcdshub.github.io/solid-attenuator
Other
1 stars 4 forks source link

Consider using `periodictable` dependency for atomic scattering factors #26

Closed klauer closed 3 years ago

klauer commented 4 years ago

e.g., periodictable.C.xray.sftable

Data source is of course the same, but note units of keV instead of eV.

klauer commented 3 years ago

Or rather xraydb, as it appears to be more accurate at high energies? (ref: https://github.com/pcdshub/pcdscalc/issues/1#issuecomment-705353803)

klauer commented 3 years ago

Back and forth with Silke/scientists over a period of weeks seemed to indicate "this attenuator IOC data source is good enough for us and may potentially be more accurate than some others".

Closing this for now, but I expect it may be back at some point. 🤷‍♂️