search

pcdshub / solid-attenuator

LCLS Solid Attenuator System IOC
https://pcdshub.github.io/solid-attenuator
Other
1 stars 4 forks source link

ENH: add support for AT1K2 with ioc-kfe-at1k2-calc #82

Closed wnwright closed 1 year ago

wnwright commented 1 year ago

Adds ioc entrypoint for AT1K2 and AT1K2 metadata

Motivation and Context

Required by https://github.com/pcdshub/pcdsdevices/pull/1086

Where Has This Been Documented?

https://confluence.slac.stanford.edu/display/L2SI/AT1K2-SOLID+SXR+Solid+Attenuator

wnwright commented 1 year ago

@klauer Seems I am getting some flake8 failures from the sys setting script, but it looks like that's the case with all of them...

klauer commented 1 year ago

Would you mind merging in with master, @wwright-slac? I think I've fixed the CI (unrelated to your PR)

Here's a quick rundown on how to do it, if the git-fu seems a bit confusing:

# Get the changes from pcdshub (assuming your pcdshub remote is 'origin')
$ git fetch origin

# Merge in the changes I just made with your checked out copy
$ git merge origin/master

# Push your merge to this PR
$ git push
wnwright commented 1 year ago

One minor tweak and then I think we're good.

Did you create pcdhsub/ioc-kfe-at1k2-calc yet?

I was going to after this is merged, and add the git submodule