search

pcdshub / transfocate

Automated calculation of beryllium lens focusing optics
https://pcdshub.github.io/transfocate
Other
1 stars 7 forks source link

MAINT: No valid solution #31

Closed teddyrendahl closed 6 years ago

teddyrendahl commented 6 years ago

Description

If the Transfocator IOC is not configured correctly we will not get a None back from the Transfocator Calculator. The high level user interface should catch this and just give an error message instead of using calling combo.show_info which just raises a different exception masking the root problem.

Also had to adjust the Travis configuration now that Miniconda will install 3.7.

Motivation

Closes #30

codecov-io commented 6 years ago

Codecov Report

Merging #31 into master will decrease coverage by 0.5%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   94.91%   94.41%   -0.51%     
==========================================
  Files           3        3              
  Lines         177      179       +2     
==========================================
+ Hits          168      169       +1     
- Misses          9       10       +1
Impacted Files Coverage Δ
transfocate/transfocator.py 94.73% <66.66%> (-1.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e567a1...0cecd22. Read the comment docs.