search

pcdshub / transfocate

Automated calculation of beryllium lens focusing optics
https://pcdshub.github.io/transfocate
Other
1 stars 7 forks source link

REF: update transfocator class to support new PLC/IOC #43

Closed klauer closed 3 years ago

klauer commented 3 years ago

Related: https://github.com/pcdshub/lcls-plc-mfx-be-lens-interlock/pull/7 https://github.com/pcdshub/ioc-mfx-tfs-lens/pull/1

klauer commented 3 years ago

Energy sweep is looking like this with black 'x' marking trips:

image

Not ideal - it's scanning a bit faster than the modbus-based responses can be retrieved. May have to add in some delays to remove or reduce that effect, then perhaps I can bring back in a line plot instead of a scatter for the "no-go" regions.

Also should pick some sensible lens combinations to make a more full sweep.

klauer commented 3 years ago

Getting closer: image

klauer commented 3 years ago

Now 99% what I expect, but some outliers that confuse me: image

klauer commented 3 years ago

A fair review, indeed. Thanks @ZLLentz 👍