REF: Designer widgets and data plugins using pydm's entrypoints

pcdshub / typhos

Automatic-yet-customizable Graphical User Interface Generation for Ophyd Devices

http://pcdshub.github.io/typhos

Other

16 stars 26 forks source link

REF: Designer widgets and data plugins using pydm's entrypoints #491

Closed klauer closed 2 years ago

klauer commented 2 years ago

Description

Removes custom designer widget plugin, instead relying on PyDM's own mechanism
Activation scripts are removed
Removes on-import data plugin instantiation. Now only applicable when pydm instantiates its data plugins.
conda-forge recipe will need updating

Upstream PR: https://github.com/slaclab/pydm/pull/861

Motivation and Context

Activation scripts are painful to write, maintain, and even use sometimes. Let's remove an additional source of failure and rely on PyDM where it's sensible to.

Closes #504

How Has This Been Tested?

Interactively

Where Has This Been Documented?

This PR text

Screenshots (if appropriate):

With the groups set as of 4cf5612:

klauer commented 2 years ago

For this PR to be ready-for-review:

We should wait until pydm's next tag
Update typhos's pinning to use that pydm
Ensure all widgets have _pyqt_designer_ settings such that they go to the appropriate "Typhos Widgets" group

klauer commented 2 years ago

This is technically ready, but it doesn't make much sense to start the review process when we want to wait on an upstream PyDM tag

klauer commented 2 years ago

PyDM v1.16.1 is out: https://github.com/slaclab/pydm/releases/tag/v1.16.1 Marking this ready for review - will bump the required pydm version in an upcoming commit.

As a note for testing: isolated testing here would be advisable, but what matters most (of course!) is our final inclusion into pcds-envs.

tangkong commented 2 years ago

This looks good to me, and I like the idea of it a lot. I don't have designer set up yet, so that part of my review will be delayed. (hopefully not too long)

CI failed due to a timeout on py3.8 specifically. I restarted the job but it looks to be a persistent problem.

klauer commented 2 years ago

I'm (fortunately) seeing the hang here locally:

typhos/tests/test_suite.py::test_suite_save_util PASSED                                                                           [ 85%]:

ZLLentz commented 2 years ago

All of the updates here are good and well-motivated The test suite hanging is perplexing and doesn't seem to be in the same place every time

klauer commented 2 years ago

Force-pushed to remove deprecation fixes and isolate this enhancement proposal

klauer commented 2 years ago

It hasn't significantly changed, @ZLLentz, but it's still segfaulting randomly

ZLLentz commented 2 years ago

@klauer do we need to run this a few times until we catch the segfault? All the other typhos builds are passing consistently now (and this one even passed this time)

klauer commented 2 years ago

@ZLLentz yes, that would be advisable

ZLLentz commented 2 years ago

Should we merge this, then? You've eliminated all the CI issues

klauer commented 2 years ago

I think if all looks good here, we should probably merge. I admittedly didn't dig back into the code to re-self-review, I was just hoping that the CI would be fixed...

Edit: worth reiterating for the next tag:

conda-forge recipe will need updating