search

pcdshub / typhos

Automatic-yet-customizable Graphical User Interface Generation for Ophyd Devices
http://pcdshub.github.io/typhos
Other
16 stars 26 forks source link

DOC: write release notes for v2.3.2 #512

Closed ZLLentz closed 2 years ago

ZLLentz commented 2 years ago

https://github.com/pcdshub/typhos/compare/v2.3.1...master

ZLLentz commented 2 years ago

Maybe. I do see that this PR failed travis haha

ZLLentz commented 2 years ago

I'll hijack my own docs PR here to fix the CI

ZLLentz commented 2 years ago

The happi stuff is exploding here, can look again tomorrow

tangkong commented 2 years ago

I wonder if this has anything to do with the happi caching behavior I saw messing with the lightpath tests...

tangkong commented 2 years ago

Oh the cli tests fail because now the happi.cfg can be interpreted as relative paths. We can just have path=happi.json

Also in utils.py::code_from_device and plugins.happi.py::HappiConnection.add_listener we should change client.find_device to client.find_item

ZLLentz commented 2 years ago

I'm currently trying to update my offline conda env to figure out what else is wrong beyond that- TravisCI segfaulting and showing no output is less than helpful

ZLLentz commented 2 years ago

Passes locally now, thankfully the notes already say "fixed test suite"

ZLLentz commented 2 years ago

Segfault on py37, rerunning full suite a few times to see if it's isolated to py37 Not observed locally

ZLLentz commented 2 years ago

py37 seg faulted 3 times consistently while the others didn't. It seems to happen on the "run the executable and see what happens" test.

ZLLentz commented 2 years ago

Ok we're finally here, I'm going to merge and tag