search

pcdshub / typhos

Automatic-yet-customizable Graphical User Interface Generation for Ophyd Devices
http://pcdshub.github.io/typhos
Other
16 stars 26 forks source link

MNT: add parents for internal uses of TyphosStatusThread #514

Closed ZLLentz closed 2 years ago

ZLLentz commented 2 years ago

Description

Set parent=self for each of the uses of TyphosStatusThread

Motivation and Context

I don't think these thread objects get cleaned up properly due to being orphaned, so this might cause weird on-shutdown behavior that interferes with e.g. the lightpath test suite. It's not really clear though.

How Has This Been Tested?

N/A Kind of just hoping the unit tests still pass

Where Has This Been Documented?

N/A

tangkong commented 2 years ago

Somehow this stalls the test suite to the point of failure. 🤔

klauer commented 2 years ago

Nothing is easy...

And also this looks like a bug I may have had something to do with: https://app.travis-ci.com/github/pcdshub/typhos/jobs/581496260#L662

tangkong commented 2 years ago

The difference in behavior between the PIP-build-with-tests and Python3.x checks has always perplexed me. In the first case the bug Ken points out prevents pytest from starting, while in the later Python checks pytest runs partially. Time to dig into the ci helpers I guess

klauer commented 2 years ago

These changes appear to be unrelated to the failure. Note that the CLI tests are stalling on a ui-change-only PR: https://app.travis-ci.com/github/pcdshub/typhos/jobs/581617995

ZLLentz commented 2 years ago

Thanks again for fighting through the CI maze Ken

klauer commented 2 years ago

👍 I'm just glad it's over with... for now 🙈