search

pcdshub / typhos

Automatic-yet-customizable Graphical User Interface Generation for Ophyd Devices
http://pcdshub.github.io/typhos
Other
16 stars 26 forks source link

BUG: do not wait for lazy connections in SignalPanel #519

Closed tangkong closed 2 years ago

tangkong commented 2 years ago

Description

Motivation and Context

Found in working with lightpath that devices with area detectors would wait for every signal to time out when creating a detailed screen. https://github.com/pcdshub/lightpath/issues/161

The issue could be solved by enforcing no_lazy_wait_for_connection at device creation, but this catches devices regardless of how they were created

How Has This Been Tested?

Works in lightpath interactively. Test suite passed locally, but severely slowed the typing of this pr text

Where Has This Been Documented?

This PR text.

ZLLentz commented 2 years ago

Test suite passed locally, but severely slowed the typing of this pr text

I did the same thing to myself last time I worked on typhos. The test suite pops up windows that briefly take the focus which is very disruptive to ongoing typing

tangkong commented 2 years ago

I forgot about this little bug fix. I'll merge this tomorrow if there's no objections

tangkong commented 2 years ago

When I first ran into this I think I had a reason for putting it here, but time erodes all.