pcdshub / typhos

Automatic-yet-customizable Graphical User Interface Generation for Ophyd Devices
http://pcdshub.github.io/typhos
Other
16 stars 24 forks source link

PERF: set text size on resize event, not on paint event, to avoid 100% cpu #604

Closed ZLLentz closed 1 month ago

ZLLentz commented 2 months ago

Description

Move the dynamic text resizing to resize event so it doesn't happen every frame and use the entire cpu

Motivation and Context

https://jira.slac.stanford.edu/browse/ECS-5143

How Has This Been Tested?

Interactively to observe the usage Tests slightly adjusted so they still pass (previously was looking for the paint event)

Where Has This Been Documented?

Here and in release notes

Pre-merge checklist

ZLLentz commented 2 months ago

This is a draft for now Robert and I figured this out together deploying in dev_conda

ZLLentz commented 1 month ago

If the tests pass here, then something in #606 is breaking the suite. I have at least one guess already. If the tests fail here, then there's a more fundamental issue.

ZLLentz commented 1 month ago

I guess I'll be taking a stab at an independent "fix atef CI tests" PR. I'll start by comparing package versions.

tangkong commented 1 month ago

I guess I'll be taking a stab at an independent "fix atef CI tests" PR. I'll start by comparing package versions.

Do you mean typhos here? Or did something about atef die without me knowing?

ZLLentz commented 1 month ago

I meant typhos