pcdshub / typhos

Automatic-yet-customizable Graphical User Interface Generation for Ophyd Devices
http://pcdshub.github.io/typhos
Other
16 stars 24 forks source link

ENH: improved wait status and positioner timeout messages #606

Closed ZLLentz closed 1 month ago

ZLLentz commented 1 month ago

Description

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Here only

Screenshots (if appropriate):

Friendly (doesn't say error) and verbose (says the timeout in tooltip) timeout message image

Goes away once the move completes image

Normal errors propagate from the status if available image

Pre-merge checklist

ZLLentz commented 1 month ago

The CI here is going to need a close look...

ZLLentz commented 1 month ago

offline tests py39: all passing online tests py39 conda: one failure, widgets not cleaned up all other online tests: segfault on something somewhat adjacent to what I worked on here

ZLLentz commented 1 month ago

Switching to a simpler ticket in attempt to isolate the problem

ZLLentz commented 1 month ago

I'm going to make some more small adjustments here:

And then I'll solicit some opinions

tangkong commented 1 month ago

I only see 5 instances of TyphosStatusThread in our org, all of which seem to be covered in this PR.